POV-Ray

The Persistence of Vision Raytracer (POV-Ray).

This is the legacy Bug Tracking System for the POV-Ray project. Bugs listed here are being migrated to our github issue tracker. Please refer to that for new reports or updates to existing ones on this system.

Tasklist

FS#83 - redundant code in pvengine.cpp

Attached to Project: POV-Ray
Opened by Christoph Lipka (clipka) - Monday, 22 March 2010, 15:52 GMT
Last edited by Christoph Lipka (clipka) - Friday, 21 May 2010, 15:25 GMT
Task Type Possible Bug
Category Source code
Status Closed
Assigned To Christoph Lipka (clipka)
Operating System All
Severity Very Low
Priority Normal
Reported Version 3.70 beta 36
Due in Version 3.70 beta 37
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

In pvengine.cpp (file revision 154), lines 4003-4006 are exact duplicates of lines 3999-4002:

3997    case KEYWORD_LOOKUP_MESSAGE :
3998         hh_aklink.pszKeywords = (LPCSTR) lParam ;

3999         if (strncmp (hh_aklink.pszKeywords, "oooo", 4) == 0)
4000           hh_aklink.pszKeywords = ""  ;
4001         if (strncmp (hh_aklink.pszKeywords, "//", 2) == 0)
4002           hh_aklink.pszKeywords = ""  ;

4003         if (strncmp (hh_aklink.pszKeywords, "oooo", 4) == 0)
4004           hh_aklink.pszKeywords = ""  ;
4005         if (strncmp (hh_aklink.pszKeywords, "//", 2) == 0)
4006           hh_aklink.pszKeywords = ""  ;

4007         HtmlHelp (NULL, engineHelpPath, HH_KEYWORD_LOOKUP, (DWORD_PTR) &hh_aklink) ;
4008         return (true) ;

This duplication appears pretty much useless to me - or am I missing something?

This task depends upon

Closed by  Christoph Lipka (clipka)
Friday, 21 May 2010, 15:25 GMT
Reason for closing:  Fixed
Additional comments about closing:  No negative beta tester feedback after almost 4 weeks that would indicate any problems with this change.
Comment by Christoph Lipka (clipka) - Thursday, 15 April 2010, 13:37 GMT

fixed with change #4940

Loading...